Allow the subscription broadcast job queue to be configured #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable. Is there any reason to keep the event around apart from preserving backwards compatibility? Can you imagine any, possibly obscure, use cases for it? |
|
No I thought about it but the only reason I didn’t remove it was BC to keep the in 4.x. I think the event was a bad choice in this case since I can’t think of any reason a user might want to listen to this even except for maybe analytical purposes, but that doesn’t really sound like a valid reason either to be honest. |
spawnia
reviewed
Apr 19, 2020
|
@stayallive please add an entry both in |
|
@spawnia I've added the changelog and upgrade docs but I'm not sure about the |
# Conflicts: # CHANGELOG.md # composer.json
spawnia
pushed a commit
that referenced
this pull request
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1300.
Changes
Uses a "proper" queue job so we can define a custom queue from the configuration file to queue all broadcast jobs on.
Breaking changes
None.