Add more return type hints (#1273)

docs/tutorial/README.md

@@ -187,7 +187,7 @@ use Illuminate\Database\Migrations\Migration;
 
 class CreatePostsTable extends Migration
 {
-    public function up()
+    public function up(): void
     {
         Schema::create('posts', function (Blueprint $table) {
             $table->increments('id');
@@ -198,7 +198,7 @@ class CreatePostsTable extends Migration
         });
     }
 
-    public function down()
+    public function down(): void
     {
         Schema::dropIfExists('posts');
     }
@@ -233,7 +233,7 @@ use Illuminate\Database\Migrations\Migration;
 
 class CreateCommentsTable extends Migration
 {
-    public function up()
+    public function up(): void
     {
         Schema::create('comments', function (Blueprint $table) {
             $table->increments('id');
@@ -243,7 +243,7 @@ class CreateCommentsTable extends Migration
         });
     }
 
-    public function down()
+    public function down(): void
     {
         Schema::dropIfExists('comments');
     }

src/Execution/Arguments/ArgPartitioner.php

@@ -147,7 +147,7 @@ protected static function attachNestedArgResolver(string $name, Argument &$argum
      * @param  \Nuwave\Lighthouse\Execution\Arguments\ArgumentSet  $argumentSet
      * @return \Nuwave\Lighthouse\Execution\Arguments\ArgumentSet[]
      */
-    public static function partition(ArgumentSet $argumentSet, \Closure $predicate)
+    public static function partition(ArgumentSet $argumentSet, \Closure $predicate): array
     {
         $matched = new ArgumentSet();
         $notMatched = new ArgumentSet();

src/Execution/Arguments/ArgumentSet.php

@@ -154,7 +154,7 @@ public function enhanceBuilder($builder, array $scopes, Closure $directiveFilter
      * @param  \Nuwave\Lighthouse\Execution\Arguments\ArgumentSet  $argumentSet
      * @param  \Illuminate\Database\Query\Builder|\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|\Illuminate\Database\Eloquent\Relations\Relation  $builder
      */
-    protected static function applyArgBuilderDirectives(self $argumentSet, &$builder, Closure $directiveFilter = null)
+    protected static function applyArgBuilderDirectives(self $argumentSet, &$builder, Closure $directiveFilter = null): void
     {
         foreach ($argumentSet->arguments as $argument) {
             $value = $argument->toPlain();

src/Pagination/PaginationArgs.php

@@ -3,6 +3,7 @@
 namespace Nuwave\Lighthouse\Pagination;
 
 use GraphQL\Error\Error;
+use Illuminate\Contracts\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Arr;
 use Laravel\Scout\Builder as ScoutBuilder;
 
@@ -85,9 +86,8 @@ protected static function calculateCurrentPage(int $first, int $after, int $defa
      * Apply the args to a builder, constructing a paginator.
      *
      * @param \Illuminate\Database\Query\Builder $builder
-     * @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
      */
-    public function applyToBuilder($builder)
+    public function applyToBuilder($builder): LengthAwarePaginator
     {
         if ($builder instanceof ScoutBuilder) {
             return $builder->paginate($this->first, 'page', $this->page);

src/Support/Http/Controllers/GraphQLController.php

@@ -9,6 +9,7 @@
 use Nuwave\Lighthouse\Execution\GraphQLRequest;
 use Nuwave\Lighthouse\GraphQL;
 use Nuwave\Lighthouse\Support\Contracts\CreatesResponse;
+use Symfony\Component\HttpFoundation\Response;
 
 class GraphQLController extends Controller
 {
@@ -46,10 +47,8 @@ public function __construct(
 
     /**
      * Execute GraphQL query.
-     *
-     * @return \Symfony\Component\HttpFoundation\Response
      */
-    public function query(GraphQLRequest $request)
+    public function query(GraphQLRequest $request): Response
     {
         $this->eventsDispatcher->dispatch(
             new StartRequest($request)

src/Support/Http/Middleware/AcceptJson.php

@@ -19,7 +19,7 @@ class AcceptJson
     /**
      * Force the Accept header of the request.
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Symfony\Component\HttpFoundation\Response|\Illuminate\Http\JsonResponse
      */
     public function handle(Request $request, Closure $next)
     {

src/Support/Http/Middleware/AttemptAuthentication.php

@@ -36,18 +36,18 @@ public function handle($request, Closure $next, ...$guards)
 
     /**
      * Attempt to authenticate the user, but don't do anything if they are not.
-     *
-     * @return void
      */
-    protected function attemptAuthentication(array $guards)
+    protected function attemptAuthentication(array $guards): void
     {
         if (empty($guards)) {
             $guards = [null];
         }
 
         foreach ($guards as $guard) {
             if ($this->auth->guard($guard)->check()) {
-                return $this->auth->shouldUse($guard);
+                $this->auth->shouldUse($guard);
+
+                return;
             }
         }
     }

tests/Integration/Execution/DataLoader/ModelRelationFetcherTest.php

@@ -98,7 +98,7 @@ public function testGetsPolymorphicRelationship(): void
         $this->assertCount($first, $tasks->first()->tags);
     }
 
-    protected function makePaginationArgs(int $first)
+    protected function makePaginationArgs(int $first): PaginationArgs
     {
         $paginatorArgs = new PaginationArgs();
         $paginatorArgs->first = $first;

tests/Integration/Execution/MutationExecutor/BelongsToManyTest.php

@@ -550,7 +550,7 @@ public function testCanUpsertUsingCreationWithBelongsToMany(): void
         $this->assertSame('is_user', $role->name);
     }
 
-    public function existingModelMutations()
+    public function existingModelMutations(): array
     {
         return [
             ['Update action' => 'update'],

tests/Integration/Execution/MutationExecutor/BelongsToTest.php

@@ -246,7 +246,7 @@ public function testCanUpsertWithNewBelongsTo(): void
         ]);
     }
 
-    public function testUpsertBelongsToWithoutId()
+    public function testUpsertBelongsToWithoutId(): void
     {
         $this->graphQL(/** @lang GraphQL */ <<<'GRAPHQL'
         mutation {
@@ -465,7 +465,7 @@ public function testCanUpsertUsingCreateAndUpdateUsingUpsertBelongsTo(): void
         ]);
     }
 
-    public function existingModelMutations()
+    public function existingModelMutations(): array
     {
         return [
             ['Update action' => 'update'],

tests/Integration/Execution/MutationExecutor/HasManyTest.php

@@ -259,7 +259,7 @@ public function testCanCreateUsingUpsertWithNewHasMany(): void
         ]);
     }
 
-    public function existingModelMutations()
+    public function existingModelMutations(): array
     {
         return [
             ['Update action' => 'update'],

tests/Integration/Execution/MutationExecutor/MorphManyTest.php

@@ -215,7 +215,7 @@ public function testAllowsNullOperations(): void
         ]);
     }
 
-    public function existingModelMutations()
+    public function existingModelMutations(): array
     {
         return [
             ['Update action' => 'update'],

tests/Integration/Execution/MutationExecutor/MorphOneTest.php

@@ -209,7 +209,7 @@ public function testAllowsNullOperations(): void
         ]);
     }
 
-    public function existingModelMutations()
+    public function existingModelMutations(): array
     {
         return [
             ['Update action' => 'update'],

tests/Integration/Execution/MutationExecutor/MorphToTest.php

@@ -177,7 +177,7 @@ public function testAllowsNullOperations(): void
         ]);
     }
 
-    public function existingModelMutations()
+    public function existingModelMutations(): array
     {
         return [
             ['Update action' => 'update'],

tests/Integration/RouteRegistrationTest.php

@@ -13,7 +13,7 @@ class RouteRegistrationTest extends TestCase
      * @param  \Illuminate\Foundation\Application  $app
      * @return string[]
      */
-    protected function getPackageProviders($app)
+    protected function getPackageProviders($app): array
     {
         return [
             LighthouseServiceProvider::class,

tests/TestCase.php

@@ -142,9 +142,8 @@ protected function getEnvironmentSetUp($app)
      * are fully dumped to the console when making requests.
      *
      * @param  \Illuminate\Foundation\Application  $app
-     * @return void
      */
-    protected function resolveApplicationExceptionHandler($app)
+    protected function resolveApplicationExceptionHandler($app): void
     {
         $app->singleton(ExceptionHandler::class, function () {
             if (AppVersion::atLeast(7.0)) {

tests/Unit/Schema/Directives/CountDirectiveTest.php

@@ -7,7 +7,7 @@
 
 class CountDirectiveTest extends TestCase
 {
-    public function testRequireRelationOrModelArgument()
+    public function testRequireRelationOrModelArgument(): void
     {
         $this->schema = '
         type Query {

tests/Utils/InterfacesSecondary/Bar.php

@@ -4,7 +4,7 @@
 
 class Bar
 {
-    public function resolve()
+    public function resolve(): void
     {
         //
     }

tests/Utils/Models/Task.php

@@ -57,7 +57,7 @@ public function image(): MorphOne
         return $this->morphOne(Image::class, 'imageable');
     }
 
-    public function scopeWhereTags(Builder $query, $tags)
+    public function scopeWhereTags(Builder $query, $tags): Builder
     {
         return $query->whereHas('tags', function (Builder $query) use ($tags) {
             $query->whereIn('name', $tags);