implement session based authentification #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
* uses session based authentification * retrives session cookie once at module init * session token expires after 15 minutes * TODO implement graceful catching of auth failure and retry getting a new token
marinsalinas
approved these changes
Apr 23, 2020
|
@maxaudron, Could you please update the documentation, to add an example of how to set session auth with terraform? |
marinsalinas
approved these changes
May 15, 2020
yannickstruyf3
pushed a commit
to yannickstruyf3/terraform-provider-nutanix
that referenced
this pull request
Nov 9, 2021
implement session based authentification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements session based authentication as an alternative to using basic auth for each request.
In case session_auth is set to true (default false)
NewClient()makes a call to/users/mewith basic auth and saves the returned cookies into the theClientobject.The
NewRequest()function uses these cookies if theClienthas them set else uses basic auth.Current limitation is that sessions expire after 15 minutes, a graceful retry mechanism should be added.