Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4 design 2.0 sdk fixes #700

Merged
merged 9 commits into from
Dec 10, 2024
Merged

V4 design 2.0 sdk fixes #700

merged 9 commits into from
Dec 10, 2024

Conversation

Haroon-Dweikat-Ntx
Copy link
Collaborator

This PR contains:

  • code fixes, rename variables and contestants, remove commented lines
  • DeleteUserById is not implemented in the GA release
  • Remove attributes are not present in the response of GA SDK, C[host_name, is_one_node_cluster_supported, is_two_node_cluster_supported, node_serial_number] in resource_nutanix_cluster_discover_unconfigured_nodes_v2.go
  • change the name of test case's from TestAccNutanix.. to TestAccV2Nutanix..

@Haroon-Dweikat-Ntx
fix TestAccV2NutanixUserGroupsDatasource_GetUserGroupByExtId name and…
0a599d8 
… remove resource print attributes during add node acc test
abhimutant
abhimutant approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@abhimutant abhimutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhimutant abhimutant merged commit 7b63563 into v4-temp-design-2.0-structure Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhishekism9450 Abhishekism9450 Abhishekism9450 left review comments

@abhimutant abhimutant abhimutant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haroon-Dweikat-Ntx @Abhishekism9450 @abhimutant