Feat/m static routes #468
Merged
Feat/m static routes #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth-kulshrestha
suggested changes
Jun 23, 2022
| @@ -162,6 +162,7 @@ func Provider() *schema.Provider { | |||
| "nutanix_foundation_central_imaged_node_details": dataSourceFCImagedNodeDetails(), | |||
| "nutanix_vpc": dataSourceNutanixVPC(), | |||
| "nutanix_vpc_list": dataSourceNutanixVPCList(), | |||
| "nutanix_static_routes": dataSourceNutanixStaticRoute(), | |||
There was a problem hiding this comment.
Do we need a singular datasource for this?
There was a problem hiding this comment.
Is it possible ?
There was a problem hiding this comment.
Also for plural datasources we should stick to one convention either : nutanix_datasource_types or nutanix_datasource_type_list for new datasources.
| return resourceNutanixStaticRouteRead(ctx, d, meta) | ||
| } | ||
|
|
||
| func resourceNutanixStaticRouteDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { |
There was a problem hiding this comment.
We need to discuss this. As you mentioned that we can delete the static route from UI.
Abhishekism9450
force-pushed
the
feat/m-staticRoutes
branch
from
c018180 to
9f2daa2
Compare
siddharth-kulshrestha
approved these changes
Jul 4, 2022
abhimutant
force-pushed
the
feat/m-staticRoutes
branch
from
e4afd60 to
74a752c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.