Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests for protection rules based datasources and resources #366

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

bhati-pradeep
Copy link
Collaborator

Updates:

  • Set description from api response in data_source_protection_rule
  • Update test_config.json and main_test.go to have fields for local_az and destination_az (availibility zones) based required uuids which will be used in tests related to protection rules.
  • Skip protection rules based data source and resource tests as per the env variable : PROTECTION_RULES_TEST_FLAG
  • Create two protection rules before using nutanix_protection_rules data source in tests.

@siddharth-nutanix
Copy link
Collaborator

siddharth-nutanix commented Mar 1, 2022

/ok-to-test

Acceptance test run status: success
Line code coverage is 59.8

@bhati-pradeep bhati-pradeep linked an issue May 10, 2022 that may be closed by this pull request
@bhati-pradeep bhati-pradeep force-pushed the impr/m-enable-protection-rules-tests branch from fc27a57 to c1f58b4 Compare May 12, 2022 20:43
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented May 12, 2022

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (0.0) is below threshold (50). Kindly add more acceptance tests.

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented May 12, 2022

/ok-to-test pc

Acceptance test run status: cancelled
Current line coverage (0.0) is below threshold (50). Kindly add more acceptance tests.

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented May 12, 2022

/ok-to-test pc

Acceptance test run status: success
Current line coverage (43.3) is below threshold (50). Kindly add more acceptance tests.

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented May 13, 2022

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.1) is below threshold (50). Kindly add more acceptance tests.

@bhati-pradeep
Copy link
Collaborator Author

TestAccNutanixSubnetsDataSource_basic failed in regression due to setup issue. Testcase passed in local run. Coverage is low due to skipping of foundation, fc and karbon related tests.

Screenshot 2022-05-13 at 12 20 32 PM

@bhati-pradeep bhati-pradeep force-pushed the impr/m-enable-protection-rules-tests branch from c1f58b4 to f8d89fa Compare August 2, 2022 08:05
@bhati-pradeep bhati-pradeep changed the base branch from master to feat/1.7.0 August 2, 2022 08:06
…g. 2.[Update] Use test_config for uuids in protection rules tests
@bhati-pradeep bhati-pradeep force-pushed the impr/m-enable-protection-rules-tests branch from f8d89fa to d751aad Compare August 2, 2022 08:08
@bhati-pradeep bhati-pradeep merged commit 7aca67f into feat/1.7.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable multi-pc tests
4 participants