Client SDK changes for foundation based bare metal provisioning #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for new foundation client
…2.[Fix] Foundation Client to make requests with correct URL and client. 3. [Fix] Foundation structs and service logic to accept error response.
siddharth-nutanix
requested changes
Feb 21, 2022
…n client creation. Add flag from http in client creation function
siddharth-nutanix
approved these changes
Feb 22, 2022
| @@ -96,7 +98,12 @@ func NewClient(credentials *Credentials, userAgent string, absolutePath string) | |||
|
|
|||
| httpClient.Transport = logging.NewTransport("Nutanix", transCfg) | |||
|
|
|||
| baseURL, err := url.Parse(fmt.Sprintf(defaultBaseURL, credentials.URL)) | |||
| protocol := "https" | |||
There was a problem hiding this comment.
lets move http / https in constants.
There was a problem hiding this comment.
You can also create a method to figure out and construct a baseURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: