Add num_queues parameter for virtual machine NICs #324
Conversation
implemented num_queues option for nics in nutanix_virtual_machine objects. If num_queues is changed for an existing nic, the VM will be restarted. If a new nic is added to a VM with a queue number specified, the VM will not be restarted. If any nic parameters besides num_queues are changed, the VM should not restart.
|
@ckhordiasma Can you pull latest master and resolve conflicts ? |
|
@ckhordiasma |
|
Hello, will get this done by the end of the week. Sorry for the delay
…On Mon, Feb 21, 2022 at 22:51 Siddharth Kulshrestha < ***@***.***> wrote:
@ckhordiasma <https://github.com/ckhordiasma>
Please resolve the conflicts and rebase with master.
—
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB53AMR2LQH25YLKIBNBAADU4MB45ANCNFSM5MBXKHTA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
had a leftover commented out line
|
/ok-to-test
|
|
@ckhordiasma Please check
|
|
/ok-to-test
|
|
when I run |
make lint |
|
/ok-to-test
|
|
/ok-to-test
|
|
Closing this PR, as #385 merged with this above commits. |
implemented num_queues option for nics in nutanix_virtual_machine
objects. If num_queues is changed for an existing nic, the VM will be
restarted. If a new nic is added to a VM with a queue number specified,
the VM will not be restarted.
If any nic parameters besides num_queues are changed, the VM should not
restart.
Also added some lines in the test file, I did not put in much because the tests were not working for me (tests would pass no matter what I added)