Improvement to create images using 'data_source_reference' #156
Conversation
saratkumar-yb
commented
Jul 6, 2020
saratkumar-yb
commented
- Improvement to create images using 'data_source_reference'
ghost
added
the
|
@kumarsarath588 can you add a test case and website documentation for this feature? |
|
@kumarsarath588 Can you rebase your PR with master and change the type from map to list with max items as 1 as Maps doesn't support inner nested schema ? Another option could be to use just TypeMap with |
| if iok && pok { | ||
| return diag.Errorf("both source_uri and source_path provided") | ||
| // if three path, uri, dsr are provided, return an error | ||
| if iok && pok && dsr { |
There was a problem hiding this comment.
What if only two values are provided ?
Then also we should raise error.
| Type: schema.TypeList, | ||
| MaxItems: 1, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
If the field is marked as "Computed" then we should ideally read its value in resourceNutanixImageRead().
It calls out to https://www.nutanix.dev/api_references/prism-central-v3/#/b3A6MjU1ODc1MTE-get-a-existing-image API.
We can set this value in read function as well.
