Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #112: Improve error handling on incorrect API calls #134

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented May 28, 2020

Validation for Delete Method used as a filter for all the server responses was removed, allowing us to pass all the responses with code 200 despite if they contain any internal error so it now allows us to remove resources in TF when they crash.

Let me know if you have a comment or concern, thanks

closes #112 #83

@PacoDw PacoDw requested review from marinsalinas and coderGo93 May 28, 2020 19:44
@ghost ghost added the size/XS label May 28, 2020
@marinsalinas
Copy link
Contributor

LGTM just keep in mind the following:

Since this change impacts all the requests, I’d recommend running all the testacc to see if there is no regressions, because I think the rest of the function is hardly invoked since it allows all 200 <= 299 responses, so I think the rest of the function needs to be refactored.

@PacoDw PacoDw merged commit 0dfcb95 into master Jun 19, 2020
@PacoDw PacoDw deleted the fix-#112 branch June 19, 2020 18:21
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
fix nutanix#112: Improve error handling on incorrect API calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling on incorrect API calls
2 participants