Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added validation to avoid nil pointer error #122

Merged
merged 1 commit into from
May 17, 2020
Merged

fix: added validation to avoid nil pointer error #122

merged 1 commit into from
May 17, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented May 11, 2020

closes #118

@PacoDw PacoDw requested review from marinsalinas and coderGo93 May 11, 2020 18:37
@ghost ghost added the size/XS label May 11, 2020
marinsalinas
marinsalinas approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it?, I can't see any test case to ensure that this is working, Otherwise LGTM!

@PacoDw
Copy link
Contributor Author

PacoDw commented May 12, 2020

yes I did @marinsalinas

@marinsalinas marinsalinas merged commit 751ce8f into master May 17, 2020
@marinsalinas marinsalinas deleted the fix-#118 branch May 17, 2020 17:48
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
@marinsalinas
Merge pull request nutanix#122 from terraform-providers/fix-#118
5944e3e 
fix: added validation to avoid nil pointer error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nutanix_subnet SIGSEGV on network rename
2 participants
@PacoDw @marinsalinas