Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #73 Added datasource of subnets #115

Merged
merged 8 commits into from
May 28, 2020
Merged

Fix #73 Added datasource of subnets #115

merged 8 commits into from
May 28, 2020

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Apr 15, 2020 •
edited
Loading

Fix for #73

  • Added data source of subnets (nutanix_subnets)
  • Added testacc for data source of subnets
  • Added subnets in provider

@coderGo93 coderGo93 self-assigned this Apr 15, 2020
@ghost ghost added the size/XL label Apr 15, 2020
@coderGo93 coderGo93 mentioned this pull request Apr 16, 2020
Closed
marinsalinas
marinsalinas suggested changes Apr 16, 2020
View reviewed changes
nutanix/data_source_nutanix_subnets.go Outdated Show resolved Hide resolved
nutanix/data_source_nutanix_subnets.go Outdated Show resolved Hide resolved
nutanix/data_source_nutanix_subnets.go Outdated Show resolved Hide resolved
@coderGo93 coderGo93 requested a review from marinsalinas April 16, 2020 23:36
@marinsalinas
Copy link
Contributor

Also please rebase from master to update this branch and run the tests again.

@coderGo93 coderGo93 requested a review from marinsalinas May 20, 2020 19:56
marinsalinas
marinsalinas suggested changes May 28, 2020
View reviewed changes
go.sum Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
nutanix/data_source_nutanix_subnets.go Outdated Show resolved Hide resolved
@coderGo93 coderGo93 requested a review from marinsalinas May 28, 2020 15:38
marinsalinas
marinsalinas approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marinsalinas marinsalinas merged commit aceb249 into master May 28, 2020
@marinsalinas marinsalinas deleted the fix-#73 branch May 28, 2020 15:56
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
@marinsalinas
Merge pull request nutanix#115 from terraform-providers/fix-#73
250f951 
Fix nutanix#73 Added datasource of subnets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@PacoDw PacoDw Awaiting requested review from PacoDw

Assignees

@coderGo93 coderGo93

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coderGo93 @marinsalinas