Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VM caused disk being deleted #34

Closed
JonKohler opened this issue Feb 26, 2019 · 12 comments · Fixed by #62
Closed

Change VM caused disk being deleted #34

JonKohler opened this issue Feb 26, 2019 · 12 comments · Fixed by #62
Assignees

Comments

@JonKohler
Copy link
Collaborator

From old repo issues, here: #220

Describe the bug
When applying VM change of CPU / RAM / Description, the disks of the VM are deleted

Expected behavior
Change CPU/RAM/Description should not delete the disks.

Logs
screenshot 2019-02-10 at 10 53 33 pm

Versions (please complete the following information):

  • OS that is executing Terraform: tried in Ubuntu and MacOS
  • Terraform v0.11.11
  • Nutanix Cluster: Prism Element: 5.9.2
  • Nutanix Prism Central: Version 5.9.2
  • Terraform provider version: v1.0.0 and github develop branch commit id ad11ad0
@ifwatts
Copy link

ifwatts commented Mar 1, 2019

Any work on this issue so far? We have a proof of concept that is also hitting this issue.

@ordenador
Copy link

ordenador commented Mar 6, 2019

I have the same issue, inclusive when apply it by second time, terraform try to change a value related to "cluster_reference:%" and "cluster_reference.name", and as final result is a VM without disk attached it

@JonKohler
Copy link
Collaborator Author

Hey folks, thanks for pinging on this. This is definitely an active bug, and we simply need to get a development sprint scheduled to take care of this. I've pinged the right folks responsible for that, we'll update here when we get that scheduled and rolling

@ifwatts
Copy link

ifwatts commented Mar 18, 2019

Any news on this?

@JonKohler
Copy link
Collaborator Author

@marinsalinas - can you look at this plz?

@rnt
Copy link

rnt commented Mar 30, 2019

Is this issue unrelated to #2 ?

This error makes the provider unusable. :(

@marinsalinas
Copy link
Contributor

Hello, @rnt and @ifwatts could you please build the binary from https://github.com/terraform-providers/terraform-provider-nutanix/tree/vdisk-update-%2323 and test if this issue is still happening.

@ifwatts
Copy link

ifwatts commented Apr 29, 2019

@marinsalinas we don't have a location to test this provider out at the moment. Are you looking for someone to do FVT on this, or you just wanted to double check?

@marinsalinas
Copy link
Contributor

marinsalinas commented Apr 29, 2019

@marinsalinas we don't have a location to test this provider out at the moment. Are you looking for someone to do FVT on this, or you just wanted to double check?

Hello @ifwatts

I just want a double check, this issue will be closed once the pull request is merged, If the problem persists we will reopen this ticket.

@ifwatts
Copy link

ifwatts commented Apr 29, 2019

@marinsalinas we don't have a location to test this provider out at the moment. Are you looking for someone to do FVT on this, or you just wanted to double check?

Hello @ifwatts

I just want a double check, this issue will be closed once the pull request is merged, If the problem persists we will reopen this ticket.

What is the ETA on the next release for this? We want to plan out a patch process for our customers

@marinsalinas
Copy link
Contributor

marinsalinas commented Jun 15, 2019

Hello @ordenador, @ifwatts @rnt.

I've done a refactor on disk_list and this issue seems to be fixed on #62 .

Can you take a look to check if in your side is solved as well?

Thanks!

@jscatala
Copy link

@marinsalinas we can check it, i can validate with @ordenador & @rnt

yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this issue Nov 9, 2021
closes nutanix#32 Categories Client API Requests and Structs
abhimutant added a commit that referenced this issue Dec 9, 2024
* address groups v4

* service groups

* resource for service groups

* crud for service groups

* CRUD for address groups

* data source for network security

* CRUD for network security

* microseg sdk pointing to internals

* datasource for directory services

* CRUD for directory service

* datasource for saml

* CRUD for idp

* delete Operation for directory service

* CRUD for user groups

* datasource for categories

* Crud and tcs for categories

* crud & test for images

* sdk versioning

* templates datasource

* datasource for template versions

* deploy templates

* spec for vms

* create Ops

* CUD ops done

* Get VMs

* VMs

* CRUD for vm disks

* CRUD/ds serial ports

* cdrom CRUD

* insert/eject cdrom

* vm actions power

* vm shutdown actions

* CRUD gpus

* associate/diassociate categories to VM

* missing return in vms

* tcs for vm resource

* tcs for vms

* acc for images

* adding more tcs

* Vms disk Tcs

* NGT install/Uninstall Resource

* tcs for serial port

* resource tcs for cdrom

* TCs for cdroms

* tcs for vm power state

* power state testcase

* shutdown Tcs

* Adding TCs for Gpus

* fixing error logic

* template versions testcases

* template deploy testcase

* template actions

* docs

* Docs for images

* docs for vm disks

* docs for serial ports

* docs for cdroms

* testcases and docs for insert eject cdrom

* docs for vm power action

* docs for shutdown vm

* docs for gpus

* vm categories docs and tcs

* docs for templates crud

* docs for template version

* docs for template guest os

* change sdk from ntnx-api-golang-sdk-internal to ntnx-api-golang-clients

* change sdk from ntnx-api-golang-sdk-internal to ntnx-api-golang-clients

* NGT Install/Uninstall on Vm implementation done, get Vm NGT configuration implementation done

* acc tests for NGT installations,

* test done, update test must be verified

* docs for NGT

* ngt_upgrade module

* test config v4 file

* fix import to use new Sdk "ntnx-api-golang-clients" insted of internal sdk

* test cases for NGT installation + update + ngt info done , docs done

* remove unused func

* dev for nutanix_ngt_insert_iso_v4

* docs for nutanix_ngt_insert_iso_v4

* ngt insert tools acc tests done

* validation on template CRUD schema, change resource name from v4 to v2

* validation on template CRUD expanders,

* fix kvPairs values, now value support values for :integer,list array of integer, array of list, map and object,
testing template create

* fix schema for template data source

* validation on get template logic

* change template data source name from v4 to v2

* add acc tests template data source

* add acc tests template data source

* add acc tests template resource

* add examples for template CRUD + info

* fix docs for template

* template deploy : change name from v4 to v2, add examples, fix acc test

* add more validations on template create and update, creating a template is only allowed using vm reference, updating can use template_version_reference or template_vm_reference, only one of them.
make version_id Optional and set the default value to the latest version of the template when it's not provided in the configuration
add more examples.
version_name and version_description both required when updating the template.

* merging VMs entities ( disks, nics, serial ports, gpu, cdrom)

* fix sdk's, use internal sdk

* create vm and relative resources during test, refactor ngt installation dev

* fix ngt dev and acc tests

* ngt examples

* change name from v4 to v2

* add `is_scsi_controller_enabled` & `is_cpu_hotplug_enabled` to vmm module

* categories attach logic

* cdrom insert eject resource

* fixing merging issues

* merge vm clone, change vm name from v4 to v2

* change nutanix_virtual_machine_v4 from v4 to v2 in test cases files

* change nutanix_virtual_machine_v4 from v4 to v2 in test cases files

* merge vm clone, change vm name from v4 to v2

* unified image resource in branch

* change subnets datasource used in test files from v4 to v2

* vm clone resource release ready

* add network device resource, assign/ remove ip address resource [includes test cases examples and docs]

* add network device datasource

* add migrate device resource with examples and docs

* change names from v4 to v2

* add guest customization resources with docs and examples

* add image placement module with docs and examples

* add ipv4_info to vmm resource schema, update sdk's to the latest

* fix image police placement, fix e-tage header so that now it passed as a pointer not as a value.

* fix images test cases,

* fix e-tage header so that now it passed as a pointer not as a value.

* set default power state for vm as ON

* fix vmm tests and run all tests on RC3 setup

* fix acc tests and Run all vmm tests on RC3 setup

* remove vendor

* change package name from vmm to vmmv2

---------

Co-authored-by: Abhishek <[email protected]>
Co-authored-by: Pradeepsingh Bhati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants