Skip to content

Commit

Permalink
Merge pull request #528 from nutanix/task/V4-integration-fixes
Browse files Browse the repository at this point in the history
V4 integration fixes
  • Loading branch information
george-ghawali authored Dec 10, 2024
2 parents 8b8d02a + 0cc9b05 commit 6109a00
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@
register: results
ignore_errors: true
changed_when: results.rc != 0
no_log: true

# verify that all nodes are unconfigured by checking the return code and stderr in all of them
- name: Assert that all cluster nodes are unconfigured
Expand Down Expand Up @@ -296,6 +297,7 @@
fail_msg: "Discover unconfigured nodes failed"
success_msg: "Discover unconfigured nodes passed"
loop: "{{ results.results }}"
no_log: true

- name: Run cluster create prechecks
ntnx_clusters_v2:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
- result.response is defined
- result.changed == true
- result.ext_id == result.response.ext_id
- result.response.cluster_reference == "{ {cluster.uuid }}"
- result.response.cluster_reference == "{{ cluster.uuid }}"
- result.response.name == "{{ vg_name }}_2"
- result.response.description == "Volume group"
- result.response.should_load_balance_vm_attachments == false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
network_info:
nic_type: "NORMAL_NIC"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
vlan_mode: "ACCESS"
ipv4_config:
should_assign_ip: true
Expand All @@ -66,7 +66,7 @@
- result.changed == false
- result.failed == false
- result.response.network_info.nic_type == "NORMAL_NIC"
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.vlan_mode == "ACCESS"
- result.response.network_info.ipv4_config.should_assign_ip == true
- result.response.backing_info.is_connected == true
Expand All @@ -86,7 +86,7 @@
network_info:
nic_type: "DIRECT_NIC"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
vlan_mode: "ACCESS"
should_allow_unknown_macs: false
ipv4_config:
Expand All @@ -106,7 +106,7 @@
- result.changed == false
- result.failed == false
- result.response.network_info.nic_type == "DIRECT_NIC"
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.vlan_mode == "ACCESS"
- result.response.network_info.ipv4_config.ip_address.value == "{{ network.managed.IPs[0] }}"
- result.response.network_info.ipv4_config.secondary_ip_address_list[0].value == "{{ network.managed.IPs[1] }}"
Expand All @@ -127,7 +127,7 @@
network_info:
nic_type: "DIRECT_NIC"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
vlan_mode: "ACCESS"
should_allow_unknown_macs: true
ipv4_config:
Expand All @@ -143,7 +143,7 @@
- result.changed == false
- result.failed == false
- result.response.network_info.nic_type == "DIRECT_NIC"
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.vlan_mode == "ACCESS"
- result.response.backing_info.is_connected == true
- result.response.network_info.should_allow_unknown_macs == true
Expand Down Expand Up @@ -221,7 +221,7 @@
network_info:
nic_type: "DIRECT_NIC"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
vlan_mode: "ACCESS"
should_allow_unknown_macs: false
ipv4_config:
Expand All @@ -238,7 +238,7 @@
- result.vm_ext_id == "{{ vm_uuid }}"
- result.ext_id is defined
- result.response.network_info.nic_type == "DIRECT_NIC"
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.vlan_mode == "ACCESS"
- result.response.network_info.should_allow_unknown_macs == false
- result.response.backing_info.is_connected == true
Expand All @@ -258,7 +258,7 @@
network_info:
nic_type: "NORMAL_NIC"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
vlan_mode: "ACCESS"
should_allow_unknown_macs: false
ipv4_config:
Expand All @@ -277,7 +277,7 @@
- result.vm_ext_id == "{{ vm_uuid }}"
- result.ext_id is defined
- result.response.network_info.nic_type == "NORMAL_NIC"
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.vlan_mode == "ACCESS"
- result.response.network_info.should_allow_unknown_macs == false
- result.response.backing_info.is_connected == true
Expand Down Expand Up @@ -322,13 +322,13 @@
- result.response.nics[2].backing_info.is_connected == true
- result.response.nics[2].network_info.nic_type == "DIRECT_NIC"
- result.response.nics[2].network_info.ipv4_config.ip_address.value is defined
- result.response.nics[2].network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.nics[2].network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.nics[2].network_info.vlan_mode == "ACCESS"
- result.response.nics[2].network_info.should_allow_unknown_macs == false
- result.response.nics[3].backing_info.is_connected == true
- result.response.nics[3].network_info.nic_type == "NORMAL_NIC"
- result.response.nics[3].network_info.ipv4_config.ip_address.value == "{{ network.managed.IPs[0] }}"
- result.response.nics[3].network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.nics[3].network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.nics[3].network_info.vlan_mode == "ACCESS"
- result.response.nics[3].network_info.should_allow_unknown_macs == false
fail_msg: "Unable to get nics ids from VM "
Expand Down Expand Up @@ -384,7 +384,7 @@
network_info:
nic_type: "NORMAL_NIC"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
vlan_mode: "ACCESS"
should_allow_unknown_macs: false
ipv4_config:
Expand Down Expand Up @@ -435,7 +435,7 @@
vm_ext_id: "{{ vm_uuid }}"
migrate_type: "ASSIGN_IP"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
ip_address:
value: "{{ network.managed.IPs[1] }}"
register: result
Expand All @@ -449,7 +449,7 @@
- result.changed == false
- result.failed == false
- result.response.migrate_type == "ASSIGN_IP"
- result.response.subnet.ext_id == '{{ network.managed.uuid }}'
- result.response.subnet.ext_id == '{{ static.uuid }}'
- result.vm_ext_id == "{{ vm_uuid }}"
fail_msg: "Unable to migrate nic to another subnet when check mode is enabled "
success_msg: "nic migrated to another subnet successfully when check mode is enabled "
Expand All @@ -462,7 +462,7 @@
vm_ext_id: "{{ vm_uuid }}"
migrate_type: "ASSIGN_IP"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
ip_address:
value: "{{ network.managed.IPs[1] }}"
register: result
Expand All @@ -474,7 +474,7 @@
- result.response is defined
- result.changed == true
- result.failed == false
- result.response.network_info.subnet.ext_id == '{{ network.managed.uuid }}'
- result.response.network_info.subnet.ext_id == '{{ static.uuid }}'
- result.response.network_info.ipv4_config.ip_address.value == "{{ network.managed.IPs[1] }}"
- result.response.network_info.nic_type == "NORMAL_NIC"
- result.response.backing_info.is_connected == false
Expand All @@ -498,7 +498,7 @@
- result.failed == false
- result.ext_id == "{{ todelete[0] }}"
- result.vm_ext_id == "{{ vm_uuid }}"
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.ipv4_config.ip_address.value == "{{ network.managed.IPs[1] }}"
fail_msg: "Unable to get nic info "
success_msg: "nic info fetched successfully "
Expand All @@ -511,7 +511,7 @@
vm_ext_id: "{{ vm_uuid }}"
migrate_type: "RELEASE_IP"
subnet:
ext_id: "{{ network.managed.uuid }}"
ext_id: "{{ static.uuid }}"
register: result
ignore_errors: true

Expand All @@ -521,7 +521,7 @@
- result.response is defined
- result.changed == true
- result.failed == false
- result.response.network_info.subnet.ext_id == '{{ network.managed.uuid }}'
- result.response.network_info.subnet.ext_id == '{{ static.uuid }}'
- result.response.network_info.ipv4_config.ip_address.value != "{{ network.managed.IPs[1] }}"
- result.response.backing_info.is_connected == false
fail_msg: "Unable to migrate nic to another subnet "
Expand All @@ -544,7 +544,7 @@
- result.failed == false
- result.ext_id == "{{ todelete[0] }}"
- result.vm_ext_id == "{{ vm_uuid }}"
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.ipv4_config.ip_address.value != "{{ network.managed.IPs[1] }}"
fail_msg: "Unable to get nic info "
success_msg: "nic info fetched successfully "
Expand Down Expand Up @@ -616,7 +616,7 @@
- result.ext_id == "{{ todelete[0] }}"
- result.vm_ext_id == "{{ vm_uuid }}"
- result.response.backing_info.is_connected == false
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.ipv4_config.ip_address.value == "{{ network.managed.IPs[1] }}"
fail_msg: "Unable to get nic info "
success_msg: "nic info fetched successfully "
Expand Down Expand Up @@ -686,7 +686,7 @@
- result.ext_id == "{{ todelete[0] }}"
- result.vm_ext_id == "{{ vm_uuid }}"
- result.response.backing_info.is_connected == false
- result.response.network_info.subnet.ext_id == "{{ network.managed.uuid }}"
- result.response.network_info.subnet.ext_id == "{{ static.uuid }}"
- result.response.network_info.ipv4_config == none
fail_msg: "Unable to get nic info "
success_msg: "nic info fetched successfully "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
- result.response.disks[1].disk_address.bus_type == "SCSI"
- result.response.disks[1].disk_address.index == 3
- result.response.gpus[0].mode == "VIRTUAL"
- result.response.gpus[0].device_id == "1"
- result.response.gpus[0].device_id == 1
- result.response.gpus[0].name == "NVIDIA T4"
- result.response.gpus[0].vendor == "NVIDIA"
- result.response.gpus[0].pci_address.segment == 0
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
dependencies:
- prepare_env

0 comments on commit 6109a00

Please sign in to comment.