send instance name also in filter when specified #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeetkaurav1st
approved these changes
Jul 11, 2022
abhijeetkaurav1st
added a commit
that referenced
this pull request
Jul 22, 2022
* Black and click version changes due to incompatibilty (#227) * fix config parser for allowing special chars in password (#228) * [AZURE PROVIDER] send instance name also in filter when specified (#233) * send instance name also in filter when specified * lint fix * Black version changes and build changes (#234) Use black module released version. Use click version that is compatible with python3.6. Update request module also to 2.27.0, as older version doesn't support latest boto3 lib Updated dependent pycryptodome and scrypt module version * minor fix * test fix * Resolving minor addition (cherry picked from commit 32bcee6bf403a830628944306bfa346fbc4a86da)
abhijeetkaurav1st
added a commit
that referenced
this pull request
Aug 22, 2023
…#233) **Problem:** Editables dictionary present in dynamic_cred in DSL file not being populated correctly on compilation. If we have our dynamic_cred defined as: ``` DynCred = dynamic_cred( '@@{username}@@', Ref.Account(CRED_PROVIDER), name="creds_domain", type="PASSWORD", variable_dict=DOMAIN_DICT, default=True, editables= { "username": False, "secret": False, "resource_type_reference": True } ) ``` The field resource_type_reference is not being populated in the compiled payload. The compiled payload for credential_definition_list has editables dict as: ``` "editables": { "username": false, "secret": false } ``` **Expected:** Compiled payload should have resource_type_reference present in the editables dict: ``` "editables":{ "username": false, "secret": false, "resource_type_reference": True } ``` **Fix:** Earlier the items not present in defaults were not being considered at the time of compilation. So, for the fix all the items are iterated after handling the defaults so that they are populated correctly in the compiled payload. (cherry picked from commit 0ce4a1d199c5e14820ac81588f206fa386e5a47f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to send instance name in filter if specified
ces: http://ph.eng.nutanix.com/D16300http://ph.eng.nutanix.com/D16299
calm: http://ph.eng.nutanix.com/D16299
Version: 3.5.0