Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] --with_endpoints option is ignored in publish runbooks #255

Closed
nutken opened this issue Jan 12, 2023 · 1 comment
Closed

[Bug] --with_endpoints option is ignored in publish runbooks #255

nutken opened this issue Jan 12, 2023 · 1 comment
Assignees
@abhijeetkaurav1st
Labels
bug Something isn't working P0 Blocker

Comments

@nutken
Copy link

nutken commented Jan 12, 2023 •
edited
Loading

Description
Specifying the --with_endpoints option when publishing a runbook does not retain the endpoints as expected

Branch/Container
release/3.5.2, master

To Reproduce
calm publish runbook --name "My Runbook" --version 1.2.3 --project myproj --with_secrets --with_endpoints --publish_to_marketplace "my-runbook"

Expected behavior
Marketplace manager will show the runbook 'Published with endpoints' checkbox checked.

Findings/Troubleshooting Done
publish_runbook in marketplace_runbook_commands.py accepts the with_endpoints parameter but doesn't pass it on to publish_runbook_as_new_marketplace_item or publish_runbook_as_new_marketplace_item, so its value defaults to False. A similar omission exists in marketplace.py, when publish_runbook_to_marketplace_manager() is called.
@nutken nutken added the bug Something isn't working label Jan 12, 2023
@abhijeetkaurav1st abhijeetkaurav1st added the P0 Blocker label Mar 17, 2023
abhijeetkaurav1st pushed a commit that referenced this issue Aug 22, 2023
@dwivediprab @abhijeetkaurav1st
Multiple tickets resolved related to 3.7.0 (#255)
6df322d 
Description:
1. Added service account auth key in describe_k8s_account (Issue Link :
https://jira.nutanix.com/browse/CALM-39091)
2. Fixed create policy description
3. Removed PRE_CREATE option as it is unavailable in PC
4. Fixed UUID None error while approving single request using dsl (Issue
link: https://jira.nutanix.com/browse/CALM-39149)

![image](https://github.com/ideadevice/calm-dsl/assets/123161845/bb42c694-4e2f-4d77-964c-656ba3a43d3b)

<img width="628" alt="image"
src="https://github.com/ideadevice/calm-dsl/assets/123161845/58329f07-9697-4ae5-abf6-ab8af0f04e70">

<img width="1077" alt="image"
src="https://github.com/ideadevice/calm-dsl/assets/123161845/25176a86-e812-4706-9d97-7746405f8ced">

(cherry picked from commit 499e66a43ac1dc84b85e6a4dd894578ae43fa559)
@dwivediprab
Copy link
Collaborator

Issue is fixed in DSL v3.7.2.2 release, Hence closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhijeetkaurav1st abhijeetkaurav1st

Labels
bug Something isn't working P0 Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abhijeetkaurav1st @nutken @dwivediprab