Cli command should return valid exit_code.

[abhijeetkaurav1st]

calm create bp command return a zero exit code even though it results in an Error. Calm command should return an exit code other than zero on error.

Use-case: within a CI/CD pipeline, the exit code is resulting is false job completion status.

[bchristianv]

Just to add some context, this particular issue was the result of basic_cred() username not being set correctly which resulted in spec.resources.credential_definition_list.0.username being None in the json. The Calm server reported the error but the calm dsl command returned 0 exit code.

[ERROR] [calm.dsl.cli.bp_commands:191] {'api_version': '3.1', 'code': 422, 'message_list': [{'details': {'spec.resources.credential_definition_list.0.username': ["None is not of type 'string'"]}, 'message': 'Request could not be processed.', 'reason': 'INVALID_REQUEST'}], 'state': 'ERROR'}
[2021-03-24 00:50:47] [DEBUG] [calm.dsl.db.handler:71] Closing connection to local DB
$ echo $?
0

I've seen other errors result in 1 exit code by the calm command, it just did not happen in this case as I would have expected.