-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set default CoreDNS version #959
Conversation
6053278
to
ca8eaec
Compare
🤔 this would actually cause a rollout of new CP machines for all workload clusters after CAREN is updated. |
f455000
to
5279b62
Compare
5279b62
to
413e47f
Compare
@jimmidyson I would like your help on the CEL validation, I couldn't find any examples can you point me to some in the repo? |
@jimmidyson I was thinking about this some more. Do we even need/want a new API type to define the upgrade strategy? (In that case I would revert the last commit and change the handler to return if dnsVar is empty) Made the change in 6541992 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
This reverts commit 5dc9fb6.
b47e1b7
to
2f7da8d
Compare
🤖 I have created a release *beep* *boop* --- ## 0.22.0 (2024-11-06) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: set default CoreDNS version by @dkoshkin in #959 ### Fixes 🔧 * fix: Use correct filename for runtime extensions component YAML by @jimmidyson in #960 ### Other Changes * docs: Update hugo and docsy by @jimmidyson in #958 * refactor: Update helm registry initialization by @jimmidyson in #961 **Full Changelog**: v0.21.0...v0.22.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
What problem does this PR solve?:
Automatically upgrades the CoreDNS version. This is done by always setting
dns.imageTag
in KCP in the CoreDNS handler, based on the mapping to the cluster's Kubernetes version.This component is different from etcd and kube-proxy that is also installed by kubeadm for a few different reasons.
This functiona call is misleading and will only update the version if its set in KCP.
To not cause a rollout of all managed clusters by changing the defaults, this PR introduces a new API to opt in. To enable this functionality a client can set this new API like so for new clusters and during cluster upgrades:
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: