Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: credential provider response secret ownership #709

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: credential provider response secret ownership #709

merged 1 commit into from
Jun 12, 2024

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Jun 10, 2024 •
edited
Loading

What problem does this PR solve?:
Saw that the owner was not getting correctly set on image credential Secret.

Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/NCN-100641

How Has This Been Tested?:

Special notes for your reviewer:

@dkoshkin dkoshkin self-assigned this Jun 10, 2024
@github-actions github-actions bot added the fix label Jun 10, 2024
@jimmidyson
Copy link
Member

Can we add an e2e test that includes creating this kind of secret? This should automatically check ownership

@dkoshkin
Copy link
Contributor Author

Can we add an e2e test that includes creating this kind of secret? This should automatically check ownership

Good idea, any hints how I can do that without adding some dummy registry into the examples?

supershal
supershal approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. can we create a unit test for this? it can be separate PR / GH issue/Jira.

@jimmidyson
Copy link
Member

@dkoshkin

any hints how I can do that without adding some dummy registry into the examples?

Ooo good question! Maybe this is easier with a envtest based test instead of our e2es?

@dkoshkin dkoshkin force-pushed the dkoshkin/fix-credential-provider-response-secret-ownership branch from eca64a3 to aa7598d Compare June 12, 2024 00:24
@dkoshkin
Copy link
Contributor Author

Adding a unit test is turning out way more complicated than it needs to be.
Using the fakeclient it fails creating the Secret because of kubernetes/kubernetes#115598. I thought that I can pre-create an empty Secret as a workaround but its still giving me this error:

Received unexpected error: failed to apply Image Registry Credentials Secret: server-side apply failed: apply patches are not supported in the fake client. Follow https://github.com/kubernetes/kubernetes/issues/115598 for the current status

I tried writing a Ginkgo test and using envtest but thats also failing because of strange error

failed to apply Image Registry Credentials Secret: server-side apply failed: the server could not find the requested resource

Here is the commit 1a8a1df

If its ok, I would like to come back to the unit tests in a separate PR. I'm trying to clean up the owner refs for all these Secrets and there are still a few other ones.

@jimmidyson
Copy link
Member

@dkoshkin

If its ok, I would like to come back to the unit tests in a separate PR. I'm trying to clean up the owner refs for all these Secrets and there are still a few other ones.

Sure, let's do that!

@jimmidyson jimmidyson merged commit dd22b9d into main Jun 12, 2024
17 checks passed
@jimmidyson jimmidyson deleted the dkoshkin/fix-credential-provider-response-secret-ownership branch June 12, 2024 08:50
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Merged
@github-actions github-actions bot added fix and removed fix labels Jun 17, 2024
faiq pushed a commit that referenced this pull request Jun 24, 2024
@jimmidyson @github-actions
release(main): v0.10.0 (#685)
2d2a3f7 
🤖 I have created a release *beep* *boop*
---


## 0.10.0 (2024-06-24)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Upgrade to Cilium v1.15.5 by @jimmidyson in
#689
* feat: Upgrade to Calico v3.28.0 by @jimmidyson in
#688
* feat: bumps caaph to v0.2.3 by @faiq in
#691
* feat: Add local-path-provisioner CSI by @jimmidyson in
#693
* feat: cluster-api v1.7.3 by @jimmidyson in
#714
* feat: bumps caaph to 0.2.4 by @faiq in
#718
* feat: Controller that copies ClusterClasses to namespaces by
@dlipovetsky in
#715
* feat: adds a mindthegap container and deployment by @faiq in
#637
* feat: implements BeforeClusterUpgrade hook by @faiq in
#682
### Fixes 🔧
* fix: use external Nutanix API types directly by @dkoshkin in
#698
* fix: Post-process clusterconfig CRDs for supported CSI providers by
@jimmidyson in
#695
* fix: nutanix credentials Secrets owner refs by @dkoshkin in
#711
* fix: credential provider response secret ownership by @dkoshkin in
#709
* fix: static credentials Secret generation by @dkoshkin in
#717
* fix: set ownerReference on imageRegistry and globalMirror Secrets by
@dkoshkin in
#720
* fix: Allow Nutanix CSI snapshot controller & webhook to run on CP
nodes by @dlipovetsky in
#723
* refactor: Use maps for CSI providers and storage classes by
@jimmidyson in
#696
* fix: CredentialProviderConfig matchImages to support registries with
port by @dkoshkin in
#724
* fix: Allow Node Feature Discovery garbage collector to run on
control-plane nodes by @dlipovetsky in
#722
* fix: RBAC role for namespace-sync controller to watch,list namespaces
by @dkoshkin in
#738
* fix: image registries not handling CA certificates by @dkoshkin in
#729
* fix: adds a docker buildx step before release-snapshot by @faiq in
#741
### Other Changes
* docs: Add released version to helm and clusterctl install by
@jimmidyson in
#683
* revert: Temporary lint config fix until next golangci-lint release
(#629) by @jimmidyson in
#686
* refactor: Delete unused code by @jimmidyson in
#687
* refactor: Reduce log verbosity for skipped handlers by @jimmidyson in
#692
* build: update Go to 1.22.4 by @dkoshkin in
#700
* build(deps): Upgrade CAPX version to v1.4.0 by @thunderboltsid in
#707
* build: Move CSI supported provider logic to script by @jimmidyson in
#703
* build: Add testifylint linter by @jimmidyson in
#706
* build: Update all tools by @jimmidyson in
#704
* refactor: rename credential provider response secret by @dkoshkin in
#710
* refactor: Simplify code by using slices.Clone by @jimmidyson in
#712
* refactor: consistently use the same SetOwnerReference function by
@dkoshkin in
#713
* refactor: kube-vip commands by @dkoshkin in
#699
* build: Fix an incorrect make variable passed to goreleaser by
@dlipovetsky in
#716
* build: Add 'chart-docs' make target by @dlipovetsky in
#727
* build: Make CAREN mindthegap reg multiarch by @jimmidyson in
#730
* Add helm values schema plugin by @dlipovetsky in
#728
* test(e2e): Use mesosphere fork with CRSBinding fix by @jimmidyson in
#736

## New Contributors
* @thunderboltsid made their first contribution in
#707

**Full Changelog**:
v0.9.0...v0.10.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supershal supershal supershal approved these changes

@jimmidyson jimmidyson jimmidyson approved these changes

Assignees

@dkoshkin dkoshkin

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoshkin @jimmidyson @supershal