Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller)!: Remove default category creation and deletion #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thunderboltsid
Copy link
Contributor

CAPX should not be concerned with creating and deleting categories. CAPX consumers should create any category they deem necessary and add it via "additionalCategories" field on NutanixMachine CR.

CAPX should not be concerned with creating and deleting categories.
CAPX consumers should create any category they deem necessary and
add it via "additionalCategories" field on NutanixMachine CR.
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.45%. Comparing base (ce22e6b) to head (9eb0a9f).

Files Patch % Lines
controllers/nutanixmachine_controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   31.14%   34.45%   +3.31%     
==========================================
  Files          14       14              
  Lines        1477     1335     -142     
==========================================
  Hits          460      460              
+ Misses       1017      875     -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant