feat: reintroduce raw-strings #117
Conversation
|
And in general, I would strongly recommend to make conceptually unrelated changes in separate PRs; that makes it much easier to review and merge preliminary steps. (You can cherry-pick commits from PRs that are required to be merged first, as long as you clearly label them as such and rebase.) |
We have enough scripts under version control with all kinds of syntax.
|
Incorporated all reviews, removed the pipeline changes that neither provide insights nor prevent anything. Maybe pipeline is a separate issue that should be addressed at some point. |
|
Ping me if/when we're ready to land this and I'll push the button. |
|
Thanks to @blindFS for the thorough review! Is there someone else who would want to review? Otherwise, I'd be ready to land, again |
mrdgo
changed the title
|
Aaah, wait a second Edit: okay, now! |
mrdgo
changed the title
| @@ -90,6 +90,10 @@ file_path: (val_string) @variable.parameter | |||
| (escaped_interpolated_content) @string | |||
| (expr_interpolated ["(" ")"] @variable.parameter) | |||
|
|
|||
| (raw_string_begin) @string | |||
There was a problem hiding this comment.
We probably don't need this, val_string will get it properly highlighted.
Discussion with tree-sitter devs
This will break the current
nvim-treesitterconfig. They have to update to also usescanner.c. People using that config might want to use "our" way to install ts-nu.After merge, it might be necessary to run
:TSUpdate nuat least once. I don't know about treesitter's caching, so let's just hope that nobody's setup breaks.With that scanner, we can also create custom logic for unquoted strings.