-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnu_legacy: with GNU, write foreground first, else background first. #54
Conversation
I will update lscolors and rust-coreutils after that |
I've been following the discussion on lscolors. This seems reasonable to me. |
@fdncred thanks. Would it be possible to merge this PR and do a new release of this crate? thanks |
I'm fine with it. @sholderbach what do you think? do you have time to publish a release here? |
Looks good! I can take care of shipping the release later. For Nushell/Reedline we would wait on the next lscolors release if we go for a minor version. Alternatively we could ship this as a patch release (API and overall design is constant, but the change in behavior could break tests for folks) I would favor going with |
@sholderbach thanks! |
@sholderbach sorry for the pressure but do you have an eta for the new release? thanks |
@sylvestre I'm trying to find someone else on the nushell team to do a release. Sorry it's taking so long. |
@sylvestre FYI - Kubouch was able to do a release for us. nu-ansi-term 0.50 is in crates.io now. We're kind of stuck now in nushell because we're waiting on a lscolors release to update to the latest nu-ansi-term, lol. |
thanks! |
Fixes:
sharkdp/lscolors#77