Use chaining for AnsiGenericString::hyperlink
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API for modifying a string to contain a hyperlink used in nushell#47 behaves different than most of our `Style`-driven APIs that basically all work through method chaining. As an alternative I propose we change the signature to take the `AnsiGenericString` by value and modify it in place. This feels more expressive for quickly building out a styled string with a link. One downside compared to a modifying setter API is that it takes a more tokens to do conditional modification with an `if` expression.
|
nice! I like this, seems intuitive when reading it to me. thanks stefan! |
|
I'm wondering if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for modifying a string to contain a hyperlink used in #47
behaves different than most of our
Style-driven APIs that basicallyall work through method chaining.
As an alternative I propose we change the signature to take the
AnsiGenericStringby value and modify it in place. This feels moreexpressive for quickly building out a styled string with a link.
One downside compared to a modifying setter API is that it takes a
more tokens to do conditional modification with an
ifexpression.cc @fdncred, @mhelsley