Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of the patch versions #44

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

sholderbach
Copy link
Member

This readds the patch versions in the cargo version specifiers to ensure
that we include a tested working version. In theory the could have been
breakage with one of the included patch versions of crates we depend on
so it is best practice to supply a full version specifier. Cargo will
automatically pull in a higher version when running cargo update or
building this library with another crate that requires a higher version.

See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

This reverts commit 313eac4.

This readds the patch versions in the cargo version specifiers to ensure
that we include a tested working version. In theory the could have been
breakage with one of the included patch versions of crates we depend on
so it is best practice to supply a full version specifier. Cargo will
automatically pull in a higher version when running `cargo update` or
building this library with another crate that requires a higher version.

See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

This reverts commit 313eac4.
@sholderbach sholderbach merged commit 024aa11 into nushell:main Jun 6, 2023
@sholderbach sholderbach deleted the revert-semver-removal branch June 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant