[W7][T11-3]Jacob Han #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerachel
reviewed
Mar 21, 2019
| randomPerson.add(random); | ||
| return new CommandResult(MESSAGE_SUCCESS, randomPerson); | ||
| } else { | ||
| return new CommandResult(MESSAGE_FAILURE); |
There was a problem hiding this comment.
Good job on checking for this event! Very user-friendly.
| new Email(Email.EXAMPLE, false), | ||
| new Address(Address.EXAMPLE, true), | ||
| new HashSet<>(Arrays.asList(new Tag("tag1"), new Tag("tag2"), new Tag("tag3"))) | ||
| new Name(Name.EXAMPLE), |
There was a problem hiding this comment.
Try to follow the checkstyle guidelines, indentation error here.
yingrong1996
pushed a commit
to yingrong1996/addressbook-level3
that referenced
this pull request
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.