forked from se-edu/addressbook-level25
-
Notifications
You must be signed in to change notification settings - Fork 73
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The project currently runs on Java 8. Since AddressBookL4 is already running on Java 9, this project should be upgraded to run on Java 9 as well for consistency. Let's upgrade the project to run on Java 9 and update the documentation accordingly. Travis currently builds the project using JDK 8. Since we are now running on Java 9, let's update it to build the project using JDK 9. Java 9 introduces a module system. By default, the set of root modules for unnamed modules is based on the java.se module instead of the java.se.ee modules. Thus, APIs in modules from the java.se.ee module, such as java.xml.bind, are not accessible by default[1]. As our project is still an unnamed module which depends on the java.xml.bind module, it is no longer compilable. To resolve this, let's update build.gradle to import the dependencies for java.xml.bind. UtilsTest uses the Integer(int) constructor for its equality test, which is deprecated from Java 9[2]. Since use of deprecated APIs is considered bad practice, let's replace this with Integer.valueOf(int). [1]: http://openjdk.java.net/jeps/261 [2]: https://docs.oracle.com/javase/9/docs/api/java/lang/Integer.html#Integer-int-
- Loading branch information
Showing
4 changed files
with
15 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters