Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactoring #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/main/java/Contacts0.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@

public class Contacts0 {

public static final int MAX_CAPACITY = 100;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic numbers bad, constants good. Nice job :)


public static void main(String[] args) {
final Scanner SCANNER = new Scanner(System.in);
System.out.println("|| ===================================================");
System.out.println("|| ===================================================");
System.out.println("|| Contacts - Version 0.0");
System.out.println("|| Welcome to Contacts!");
System.out.println("|| ===================================================");
String[][] list = new String[100][3];
showWelcomeScreen();
String[][] list = new String[MAX_CAPACITY][3];
int count = 0;
while (true) {
System.out.print("|| " + "Enter command: ");
Expand Down Expand Up @@ -146,4 +144,12 @@ public static void main(String[] args) {
}
}

private static void showWelcomeScreen() {
System.out.println("|| ===================================================");
System.out.println("|| ===================================================");
System.out.println("|| Contacts - Version 0.0");
System.out.println("|| Welcome to Contacts!");
System.out.println("|| ===================================================");
}

}
4 changes: 2 additions & 2 deletions text-ui-test/EXPECTED.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
|| ===================================================
|| ===================================================
|| Contacts - Version 0.0
|| Contacts - Version 0.1
|| Welcome to Contacts!
|| ===================================================
|| Enter command: || [Command entered:help]
|| add: Adds a person to contacts.
|| Parameters: NAME p/PHONE_NUMBER e/EMAIL
|| Example: add John Doe p/98765432 e/[email protected]
|| Example: add John Doe p/98765431 e/[email protected]
||
|| list: Displays all persons as a list with index numbers.
|| Example: list
Expand Down