[T2A2][T16-A1] Alwinson Au-yong #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okkhoy
reviewed
Feb 25, 2017
| @@ -54,7 +54,7 @@ | |||
| /** | |||
| * A platform independent line separator. | |||
| */ | |||
| private static final String LS = System.lineSeparator() + LINE_PREFIX; | |||
| private static final String LINE_SEPARATOR = System.lineSeparator() + LINE_PREFIX; | |||
| final String[] commandTypeAndParams = splitCommandWordAndArgs(userInputString); | ||
| final String commandType = commandTypeAndParams[0]; | ||
| final String commandArgs = commandTypeAndParams[1]; | ||
| final String commandType = commandTypeAndParams[COMMAND_TYPE_INDEX]; |
There was a problem hiding this comment.
good to see you have removed the magic numbers here!
| final boolean changed = ALL_PERSONS.remove(exactPerson); | ||
| if (changed) { | ||
| final boolean ischanged = ALL_PERSONS.remove(exactPerson); | ||
| if (ischanged) { |
There was a problem hiding this comment.
the idea here is correct, naming the boolean by prefixing is however, you need to follow camel casing. appropriate would be isChanged
| && !splitArgs[0].isEmpty() // non-empty arguments | ||
| && !splitArgs[1].isEmpty() | ||
| && !splitArgs[2].isEmpty(); | ||
| return splitArgs.length == PERSON_DATA_COUNT // 3 arguments |
| */ | ||
| private static String removePrefixSign(String s, String sign) { | ||
| return s.replace(sign, ""); | ||
| private static String removePrefix(String fullString, String prefix) { |
There was a problem hiding this comment.
the solution to this one is incorrect.
this one is pretty much the same as earlier. you need to change the code so that only prefix is removed.
in the current version all occurrences of prefix in fullString are removed.
|
@alwinsonauyong sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to Review