Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T2A2][W13-A3]Melvin Tan #304

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Melvin-Tan
Copy link

No description provided.

Copy link

@K1ang K1ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Melvin-Tan Some comments added. Please close the PR after reading comments.

  • There are many more possible refactoring that can be done here. Do practice if you can!

* Returns true if file path have a file name that has an extension.
*/
private static boolean hasExtensionForFilename(Path filePath) {
return filePath.getFileName().toString().lastIndexOf('.') > 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about refactoring the magic string and numbers here

@K1ang K1ang added the Reviewed label Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants