[T2A2][T16-A3][Edward Tan Wei Chong] #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review |
sooyj
reviewed
Feb 2, 2017
| @@ -54,7 +58,7 @@ | |||
| /** | |||
| * A platform independent line separator. | |||
| */ | |||
| private static final String LS = System.lineSeparator() + LINE_PREFIX; | |||
| private static final String LINE_SEPERATOR = System.lineSeparator() + LINE_PREFIX; | |||
| @@ -366,8 +374,8 @@ private static void loadDataFromStorage() { | |||
| */ | |||
| private static String executeCommand(String userInputString) { | |||
| final String[] commandTypeAndParams = splitCommandWordAndArgs(userInputString); | |||
| final String commandType = commandTypeAndParams[0]; | |||
| final String commandArgs = commandTypeAndParams[1]; | |||
| final String commandType = commandTypeAndParams[COMMAND_TYPE_INDEX]; | |||
| if (!Collections.disjoint(wordsInName, keywords)) { | ||
| matchedPersons.add(person); | ||
| } | ||
| addMatchedPerson(keywords, matchedPersons, person, wordsInName); |
| @@ -794,11 +807,11 @@ private static void addPersonToAddressBook(String[] person) { | |||
| * @return true if the given person was found and deleted in the model | |||
| */ | |||
| private static boolean deletePersonFromAddressBook(String[] exactPerson) { | |||
| final boolean changed = ALL_PERSONS.remove(exactPerson); | |||
| if (changed) { | |||
| final boolean isChanged = ALL_PERSONS.remove(exactPerson); | |||
There was a problem hiding this comment.
Good: Boolean variable naming convention.
| private static String removePrefixSign(String s, String sign) { | ||
| return s.replace(sign, ""); | ||
| private static String removePrefix(String fullString, String prefix) { | ||
| return fullString.replace(prefix, ""); |
There was a problem hiding this comment.
Code logic is not corrected. replace() changes all occurrences of the prefix string in fullString. The intention is to remove the first occurrence only.
| * @param s Parameter as a string | ||
| * @param sign Parameter sign to be removed | ||
| * @param fullString Parameter as a string | ||
| * @param prefix Parameter sign to be removed |
There was a problem hiding this comment.
Correct to update the comment. Note that you should remove the mention of "sign" in this comment too.
| @@ -989,12 +1002,12 @@ private static String extractPhoneFromPersonString(String encoded) { | |||
|
|
|||
| // phone is last arg, target is from prefix to end of string | |||
| if (indexOfPhonePrefix > indexOfEmailPrefix) { | |||
| return removePrefixSign(encoded.substring(indexOfPhonePrefix, encoded.length()).trim(), | |||
| return removePrefix(encoded.substring(indexOfPhonePrefix, encoded.length()).trim(), | |||
There was a problem hiding this comment.
Good change. Removed the ambiguous term "sign" from method name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.