feat: Ja/display input groups #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
11 times, most recently
from
f45d1d5 to
ed0018f
Compare
Render input groups as form fieldsets. Doesn't look great, though. Going to take a pass at a better UX.
If you have a lot of inputs, having groups can help organize them on the screen, but it also pads the list out and makes them even longer. This PR adds an Accordion component, then uses it to display the groups. The customer can view one group at a time (or open them all if they want to.)
Mainly to use their stepper component.
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
2 times, most recently
from
fc54c97 to
44e055f
Compare
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
from
44e055f to
8402955
Compare
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
4 times, most recently
from
9435dba to
9ac0375
Compare
Looks like there's a bug with recent version of @types/react, that causes valid Typescript to fail with some React components. This was failing builds with my install stepper UI changes. Pinning to the last working version, as recommended in the github issue , appears to have solved the problem for me. creativetimofficial/material-tailwind#528
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
from
9ac0375 to
85d87f3
Compare
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
from
ef14445 to
b4a75b7
Compare
With the error message component set up, we can return all errors and display them to the user.
10 seconds should more frequent enough
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
from
2b30bb9 to
9daa48d
Compare
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
from
18c377a to
b54d5d0
Compare
jordan-acosta
force-pushed
the
ja/display-input-groups
branch
from
b54d5d0 to
f9a7c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.