Skip to content

Fix false positive when asserting an error pointer #370

Fix false positive when asserting an error pointer

Fix false positive when asserting an error pointer #370

Triggered via pull request December 11, 2024 08:01
Status Success
Total duration 4m 50s
Artifacts

sanity.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
build
ginkgo-linter: "Expect": missing assertion method. Expected "To()", "ToNot()" or "NotTo()"
build
ginkgo-linter: "Eventually": missing assertion method. Expected "Should()" or "ShouldNot()"
build
use BeforeEach() to assign variable vWhen
build
use BeforeEach() to assign variable vContext
build
ginkgo-linter: multiple issues: timeout defined more than once; polling defined more than once
build
ginkgo-linter: multiple issues: only use time.Duration for timeout and polling in Eventually() or Consistently(); only use time.Duration for timeout and polling in Eventually() or Consistently(). Consider using `Consistently(func() bool { return true }, time.Second*10, time.Second).Should(BeTrue())` instead
build
ginkgo-linter: timeout must not be shorter than the polling interval
build
ginkgo-linter: Success matcher only support a single error value, or function with Gomega as its first parameter
build
ginkgo-linter: wrong error assertion. Consider using `Eventually(func() error { return err }).Should(Succeed())` instead
build
ginkgo-linter: Success matcher does not support multiple values
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636