Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue215: Export NUnit XML Test results #578

Merged
merged 7 commits into from
Dec 17, 2018
Merged

Issue215: Export NUnit XML Test results #578

merged 7 commits into from
Dec 17, 2018

Conversation

OsirisTerje
Copy link
Member

@OsirisTerje OsirisTerje commented Dec 13, 2018 •
edited
Loading

PR for Issue #215

CharliePoole
CharliePoole reviewed Dec 13, 2018
View reviewed changes
Copy link
Member

@CharliePoole CharliePoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with a few comments I made inline. However, I don't see that you are actually installing the extension with the engine in this PR. Was it already being installed?

src/NUnitTestAdapter/AdapterSettings.cs Outdated Show resolved Hide resolved
src/NUnitTestAdapter/AdapterSettings.cs Outdated Show resolved Hide resolved
jnm2
jnm2 requested changes Dec 16, 2018
View reviewed changes
Copy link
Contributor

@jnm2 jnm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to my knowledge. Bunch of small comments.

src/NUnitTestAdapter/AdapterSettings.cs Outdated Show resolved Hide resolved
src/NUnitTestAdapter/AdapterSettings.cs Outdated Show resolved Hide resolved
src/NUnitTestAdapter/AdapterSettings.cs Show resolved Hide resolved
src/NUnitTestAdapter/AdapterSettings.cs Show resolved Hide resolved
src/NUnitTestAdapter/AdapterSettings.cs Outdated Show resolved Hide resolved
src/NUnitTestAdapter/NUnit3TestExecutor.cs Show resolved Hide resolved
src/NUnitTestAdapter/NUnit3TestExecutor.cs Outdated Show resolved Hide resolved
src/NUnitTestAdapter/NUnit3TestExecutor.cs Outdated Show resolved Hide resolved
src/NUnitTestAdapter/NUnitTestAdapter.cs Outdated Show resolved Hide resolved
src/NUnitTestAdapter/NUnitTestAdapter.cs Show resolved Hide resolved
@OsirisTerje OsirisTerje merged commit 7b429d5 into master Dec 17, 2018
@ChrisMaddock ChrisMaddock mentioned this pull request Feb 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2 jnm2 jnm2 requested changes

@CharliePoole CharliePoole CharliePoole left review comments

@rprouse rprouse Awaiting requested review from rprouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OsirisTerje @CharliePoole @jnm2