Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the partition filter from test expansion #1179

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

chris-smith-zocdoc
Copy link
Contributor

Addressing my comment here #1138 (comment)

I saw the category filter doing this already and copied its approach. Please let me know if there is another approach you think I should take

@chris-smith-zocdoc
Copy link
Contributor Author

@dotnet-policy-service agree company="Zocdoc"

@OsirisTerje
Copy link
Member

@chris-smith-zocdoc Can you update?

@chris-smith-zocdoc
Copy link
Contributor Author

@OsirisTerje I rebased, is there anything else I should do?

If this approach is good with you I can also add tests, just need some guidance on where they should go and how to run them (I'm on Mac and am unfamiliar with Cake)

@OsirisTerje
Copy link
Member

OsirisTerje commented Jul 16, 2024

@chris-smith-zocdoc Thanks!

Building with cake is straightforward. I am not familiar with Mac command line, but if you can run either the build.cmd file or the build.ps1 (powershell), or you can create a similar one for Mac,

To build: build
To test: build -t test
To run the acceptance tests: build -t acceptance
(And for reference, to build a nuget package: build -t package)

The acceptance tests uses code for the test project and test class embedded in the test. It then starts up the test system,
includes the adapter package and run it.

@OsirisTerje
Copy link
Member

@chris-smith-zocdoc I'll merge this now, in order to get it into version 4.6.

Would be nice if you managed to get some tests around it though, but it can in a separate PR.

@OsirisTerje OsirisTerje merged commit e0c21e5 into nunit:master Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants