We no longer need ComparerParameterIndex

nunit · Apr 10, 2024 · 3b5fe01 · 3b5fe01
1 parent 54ed245
commit 3b5fe01
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/src/nunit.analyzers/CollectionAssertUsage/CollectionAssertUsageAnalyzer.cs b/src/nunit.analyzers/CollectionAssertUsage/CollectionAssertUsageAnalyzer.cs
@@ -67,26 +67,16 @@ protected override void AnalyzeAssertInvocation(OperationAnalysisContext context
                 TwoCollectionParameterAsserts.TryGetValue(methodSymbol.Name, out constraint) ||
                 CollectionAndItemParameterAsserts.TryGetValue(methodSymbol.Name, out constraint))
             {
-                var parameters = methodSymbol.Parameters;
-                string comparerParameterIndex = parameters.Length > 1 && IsIComparer(parameters[1]) ? "1" :
-                                               (parameters.Length > 2 && IsIComparer(parameters[2]) ? "2" : "0");
-
                 context.ReportDiagnostic(Diagnostic.Create(
                     collectionAssertDescriptor,
                     assertOperation.Syntax.GetLocation(),
                     new Dictionary<string, string?>
                     {
                         [AnalyzerPropertyKeys.ModelName] = methodSymbol.Name,
-                        [AnalyzerPropertyKeys.ComparerParameterIndex] = comparerParameterIndex,
                     }.ToImmutableDictionary(),
                     constraint,
                     methodSymbol.Name));
             }
         }
-
-        private static bool IsIComparer(IParameterSymbol parameterSymbol)
-        {
-            return parameterSymbol.Type.Name == "IComparer";
-        }
     }
 }
diff --git a/src/nunit.analyzers/Constants/AnalyzerPropertyKeys.cs b/src/nunit.analyzers/Constants/AnalyzerPropertyKeys.cs
@@ -4,6 +4,5 @@ internal static class AnalyzerPropertyKeys
     {
         internal const string ModelName = nameof(AnalyzerPropertyKeys.ModelName);
         internal const string MinimumNumberOfArguments = nameof(AnalyzerPropertyKeys.MinimumNumberOfArguments);
-        internal const string ComparerParameterIndex = nameof(AnalyzerPropertyKeys.ComparerParameterIndex);
     }
 }