Remove SettingsService #907
Conversation
src/NUnitEngine/EngineApiVersion.cs
Outdated
| @@ -4,5 +4,5 @@ | |||
|
|
|||
| [assembly: AssemblyProduct("NUnit Engine API")] | |||
| [assembly: AssemblyVersion("3.0.0.0")] | |||
| [assembly: AssemblyInformationalVersion("3.13.0")] | |||
| [assembly: AssemblyInformationalVersion("4.0.0")] | |||
| [assembly: AssemblyFileVersion("3.13.0")] | |||
There was a problem hiding this comment.
Think you've missed a version here. 🙂
There was a problem hiding this comment.
I think there's also a version stored in the Cake file, which should be updated in sync with these?
There was a problem hiding this comment.
Your right that I missed one. I'll fix.
However, the cake file was updated when I created dev-4.0 so doesn't need to be changed here.
| { | ||
| IService service = _serviceManager.GetService(typeof(ISettings)); | ||
| Assert.That(service, Is.SameAs(_settingsService)); | ||
| } |
There was a problem hiding this comment.
Did you mean to remove this test, rather than refactor in the same way as above?
There was a problem hiding this comment.
I realized it duplicated a check made in the InitializeServices test.
| private const string SETTINGS_FILE = "Nunit30Settings.xml"; | ||
|
|
||
| public SettingsService(bool writeable) | ||
| : base(Path.Combine(NUnitConfiguration.ApplicationDirectory, SETTINGS_FILE), writeable) { } |
There was a problem hiding this comment.
I think NUnitConfigurations.AppDirectory can also be removed now - it was only used to store settings, I think? 🙂
Fixes #873