Fix exception thrown when parsing test names #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for proactively taking care of this @CharliePoole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1510 Replaces PR #1513
@stevenaw @mikkelbu @OsirisTerje
I'd appreciate if one of you who commented on the issue would review this. Thanks to @stevenaw for the tests.
This is a somewhat adhoc change but one we will have to live with for a while unless we want to make substantial changes to how we process arguments. I suggest reading my comments on #1504.
Absent a rewrite, I've added fixups to deal with two situations:
'or/, which needed fixing so that blanks are ignored outside of quotes.", which is removed bycmd.exe. In this case, I combined a series of tokens to create a new one.The new code is no longer sensitive to white space outside of quoted argument strings.