Make DriverService a non-service #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1122
@jnm2 @mikkelbu I've been merging some changes without a review, but I think this one needs to be looked at by one or both of you. It's the last service in core except for ExtensionService itself so once it's gone I can move all of the service and servicemanager implementation to the engine itself.
The DriverService probably needs a new name but I haven't done that yet. Suggestions?
The Azure build is hanging. At first I thought it may be due to problems they were having but it's always in the same place... right after the net20 engine tests run. Looking for ideas.
FYI I had to temporarily remove the bundled extensions from the msi build, since they no longer work with the changes to the API.