Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: markdownlint-cli2-config is removed use --config flag instead #884

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

mikkelbu
Copy link
Member

@mikkelbu mikkelbu commented Jan 20, 2024

Copy link

github-actions bot commented Jan 20, 2024

@manfred-brands
Copy link
Member

It seems to be a bit stricter on tables. They need a closing '|' for each row now.

The default is "consistent", so the first table defines the format.
And the format is "leading_and_trailing"
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stevenaw
Copy link
Member

Thanks for looking into this @mikkelbu !

@SeanKilleen
Copy link
Member

Thanks @mikkelbu !

@SeanKilleen SeanKilleen merged commit a1fff4a into master Jan 20, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 20, 2024
…ead (#884)

* chore: `markdownlint-cli2-config` is removed use `--config` flag instead

The entry point `markdownlint-cli2-config` was removed in markdownlint-cli2
version 0.12.0.

See https://github.com/DavidAnson/markdownlint-cli2/blob/82c791e94c2e2ab2119437d61c722c8e0c20d6c9/CHANGELOG.md?plain=1#L11-L12

And failed build in https://github.com/nunit/nunit.analyzers/actions/runs/7596383794/job/20690026186?pr=675

* chore: Also satisfy "MD055 - Table pipe style"

The default is "consistent", so the first table defines the format.
And the format is "leading_and_trailing"

---------

Co-authored-by: Mikkel Bundgaard <[email protected]> a1fff4a
@mikkelbu mikkelbu deleted the chore/use-config-flag branch January 20, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdownlint-cli2 has changed how to pass configuration
4 participants