-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: markdownlint-cli2-config
is removed use --config
flag instead
#884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entry point `markdownlint-cli2-config` was removed in markdownlint-cli2 version 0.12.0. See https://github.com/DavidAnson/markdownlint-cli2/blob/82c791e94c2e2ab2119437d61c722c8e0c20d6c9/CHANGELOG.md?plain=1#L11-L12 And failed build in https://github.com/nunit/nunit.analyzers/actions/runs/7596383794/job/20690026186?pr=675
It seems to be a bit stricter on tables. They need a closing '|' for each row now. |
The default is "consistent", so the first table defines the format. And the format is "leading_and_trailing"
manfred-brands
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for looking into this @mikkelbu ! |
stevenaw
approved these changes
Jan 20, 2024
Thanks @mikkelbu ! |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 20, 2024
…ead (#884) * chore: `markdownlint-cli2-config` is removed use `--config` flag instead The entry point `markdownlint-cli2-config` was removed in markdownlint-cli2 version 0.12.0. See https://github.com/DavidAnson/markdownlint-cli2/blob/82c791e94c2e2ab2119437d61c722c8e0c20d6c9/CHANGELOG.md?plain=1#L11-L12 And failed build in https://github.com/nunit/nunit.analyzers/actions/runs/7596383794/job/20690026186?pr=675 * chore: Also satisfy "MD055 - Table pipe style" The default is "consistent", so the first table defines the format. And the format is "leading_and_trailing" --------- Co-authored-by: Mikkel Bundgaard <[email protected]> a1fff4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883
The entry point
markdownlint-cli2-config
was removed in markdownlint-cli2 version 0.12.0.See https://github.com/DavidAnson/markdownlint-cli2/blob/82c791e94c2e2ab2119437d61c722c8e0c20d6c9/CHANGELOG.md?plain=1#L11-L12
And failed build in https://github.com/nunit/nunit.analyzers/actions/runs/7596383794/job/20690026186?pr=675