cobra #427
Closed
cobra #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was still pointing to git.numtide.com Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
Removes dependency on latest build of treefmt from inside the repo. Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
`treefmt.toml` has been extended to include an entry for most of the flags that can be passed to `treefmt`. In addition, values can now be specified via the environment, prefixed with `TREEFMT_`. Finally, the order of precedence for value lookup has been fixed: flag -> env -> treefmt.toml. Closes #351
Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
Signed-off-by: Brian McGee <[email protected]>
zimbatm
approved these changes
Oct 9, 2024
| Filesystem Type = "filesystem" | ||
| Auto Type = iota | ||
| Git Type = iota | ||
| Filesystem |
| @@ -1,40 +1,17 @@ | |||
| /* | |||
| Copyright © 2024 NAME HERE <EMAIL ADDRESS> | |||
| */ | |||
|
Decided to break this up into smaller PRs and refine some things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
treefmt.tomlhas been extended to include an entry for most of the flags that can be passed totreefmt.In addition, values can now be specified via the environment, prefixed with
TREEFMT_.Finally, the order of precedence for value lookup has been fixed: flag -> env ->
treefmt.toml.On a different note, I imported the more stringent rules for
golangci-lintfrom go-nix and fixed many issues. I started removing globals, but I will leave the cache and format packages for the next few PRs, as I want to review and incorporate some of the work I did in #349.Changelog
TODO
Closes #351