Unable to create treefmt eval cache shouldn't be fatal #327
Labels
bug
Something isn't working
Comments
flokli
changed the title
|
Running with |
|
I still think the proper fix for this would be to throw a warning if the cache couldn't be configured, but then proceed without cache. |
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this issue
Jul 1, 2024
See NixOS/nixpkgs#323753 for details. Changes: * git: temporarily comment out dottime patch (it doesn't apply, but it's not critical) * third-party/cgit: use an older git version where dottime patch still applies * 3p/crate2nix: remove crate2nix patches included in latest release * tvix: remove unneeded defaultCrateOverrides (upstreamed to nixpkgs) * tvix: regenerate Cargo.nix * tvix/nix-compat: remove unnused AtermWriteable::aterm_bytes pub(crate) function * tvix/nix-compat: remove redundant trait bounds * tvix/glue: use clone_into() to set drv.{builder,system} * tools/crate2nix: apply workaround for numtide/treefmt#327 * toold/depotfmt: expose treefmt config as passthru * tools/crate2nix: undo some more hacks in the crate2nix-check drv Change-Id: Ifbcedeb3e8f81b2f6ec1dbf10189bfa6dfd9c75c Co-Authored-By: Florian Klink <[email protected]> Reviewed-on: https://cl.tvl.fyi/c/depot/+/11907 Reviewed-by: tazjin <[email protected]> Tested-by: BuildkiteCI Reviewed-by: flokli <[email protected]>
tvlbot
pushed a commit
to tvlfyi/kit
that referenced
this issue
Jul 1, 2024
See NixOS/nixpkgs#323753 for details. Changes: * git: temporarily comment out dottime patch (it doesn't apply, but it's not critical) * third-party/cgit: use an older git version where dottime patch still applies * 3p/crate2nix: remove crate2nix patches included in latest release * tvix: remove unneeded defaultCrateOverrides (upstreamed to nixpkgs) * tvix: regenerate Cargo.nix * tvix/nix-compat: remove unnused AtermWriteable::aterm_bytes pub(crate) function * tvix/nix-compat: remove redundant trait bounds * tvix/glue: use clone_into() to set drv.{builder,system} * tools/crate2nix: apply workaround for numtide/treefmt#327 * toold/depotfmt: expose treefmt config as passthru * tools/crate2nix: undo some more hacks in the crate2nix-check drv Change-Id: Ifbcedeb3e8f81b2f6ec1dbf10189bfa6dfd9c75c Co-Authored-By: Florian Klink <[email protected]> Reviewed-on: https://cl.tvl.fyi/c/depot/+/11907 Reviewed-by: tazjin <[email protected]> Tested-by: BuildkiteCI Reviewed-by: flokli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I'm running
treefmtinside a Nix build.Since the bump to 2.x, this started to fail, as
treefmtfails on not being able to create some cache files.This should be a recoverable error, potentially trying to use tmpdir instead, or just not creating the cache at all.
To Reproduce
Steps to reproduce the behavior:
treefmtinside a Nix derivationtreefmt: error: could not resolve local path for the cache: could not create any of the following paths: /homeless-shelter/.cache/treefmt/eval-cacheExpected behavior
Files get formatted.
System information
Additional context
The text was updated successfully, but these errors were encountered: