This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
MAINT: ban setting ndarray.dtype
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in https://github.com/numpy/numpy-stubs/issues/7. Though this is valid NumPy, users should be using `ndarray.view` instead of setting the dtype, and setting the dtype prevents sensibly making `ndarray` generic over dtype because of situations like this: ``` x = np.ones((2,), dtype=np.int64) # type is ndarray[np.int64] x.dtype = np.bool_ # What is the type now? ``` If someone really wants to do this, they will now have add an ignore, which should make it clear that type safety is going out the window.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in https://github.com/numpy/numpy-stubs/issues/7.
Though this is valid NumPy, users should be using
ndarray.viewinstead of setting the dtype, and setting the dtype prevents sensibly
making
ndarraygeneric over dtype because of situations like this:If someone really wants to do this, they will now have add an ignore,
which should make it clear that type safety is going out the window.