Type tao #40
Merged
Type tao #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #40 +/- ##
===========================================
+ Coverage 51.03% 62.48% +11.45%
===========================================
Files 10 9 -1
Lines 1354 1141 -213
===========================================
+ Hits 691 713 +22
+ Misses 663 428 -235
|
iintSjds
reviewed
May 5, 2023
| @@ -186,39 +244,48 @@ function chebdiff(n, x, f, invmat) | |||
| return sum(intw .* f) | |||
| end | |||
|
|
|||
| struct BaryCheb1D{N} | |||
| struct BaryCheb1D{N,T} | |||
There was a problem hiding this comment.
Shall we add a restriction like T<:AbstractFloat to aviod wrong inputs like Int?
iintSjds
reviewed
May 5, 2023
| @@ -401,7 +401,7 @@ the grid has 2 segments, 2*(M+1)*N+1 points. | |||
| seg = 2 | |||
| size = (M+1)*N*seg+1 | |||
| bounds = @SVector[0.0,β] | |||
| return UniLogs{Float64,size,seg}(bounds,minterval,M,N) | |||
There was a problem hiding this comment.
Why is this file changed? Perhaps this file should be removed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Cheb grid available for arbitrary type of Float.