Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barychebdiff #25

Merged
merged 4 commits into from
May 4, 2022
Merged

Barychebdiff #25

merged 4 commits into from
May 4, 2022

Conversation

iintSjds
Copy link
Member

@iintSjds iintSjds commented May 3, 2022

Fixed bug in chebyshev.jl, now differentiate works for BaryCheb.
Fixed bug throwing error when creating LogDensedGrid with one dense point.

@iintSjds iintSjds requested review from houpc and kunyuan May 3, 2022 20:19
@iintSjds iintSjds added the bug Something isn't working label May 3, 2022
@iintSjds iintSjds linked an issue May 3, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #25 (8fff5a9) into master (b0de96a) will increase coverage by 0.37%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   42.75%   43.12%   +0.37%     
==========================================
  Files           9        9              
  Lines        1104     1113       +9     
==========================================
+ Hits          472      480       +8     
- Misses        632      633       +1     
Impacted Files Coverage Δ
src/grid/interpolate.jl 60.77% <ø> (ø)
src/grid/composite.jl 96.29% <50.00%> (+0.96%) ⬆️
src/grid/chebyshev.jl 81.70% <77.77%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0de96a...8fff5a9. Read the comment docs.

@kunyuan kunyuan merged commit 41536ae into master May 4, 2022
@kunyuan kunyuan deleted the barychebdiff branch May 4, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A bug in LogDensedGrid
3 participants