Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off by one bug in _filterLikelihoods redThreshold vs yellowThreshold #3870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Off by one bug in _filterLikelihoods redThreshold vs yellowThreshold #3870

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2019

No description provided.

@ghost ghost closed this Mar 22, 2019
@ghost ghost reopened this Mar 22, 2019
@rhyolight
Copy link
Member

rhyolight commented Mar 25, 2019 •
edited
Loading

@kyle-sorensen Your change has cause a couple tests to fail. If there is an off by one bug, then these tests must be incorrectly defined. Can you read them to confirm that?

  • AnomalyLikelihoodAlgorithmTest.testFilterLikelihodsInputType
  • AnomalyLikelihoodAlgorithmTest.testFilterLikelihoods

@breznak breznak mentioned this pull request May 31, 2019
Open
5 tasks
@breznak
Copy link
Member

breznak commented May 31, 2019

Subscribing,
@kyle-sorensen if you fix this, could you please make a PR also to htm-community/htm.core#469 ? Would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhyolight @breznak