Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share cai-injected photo instead of sharable copy #845

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Share cai-injected photo instead of sharable copy #845

merged 1 commit into from
Sep 2, 2021

Conversation

vincent10400094
Copy link
Contributor

@vincent10400094 vincent10400094 commented Aug 30, 2021 •
edited
Loading

#844

  • Share CAI-injected photo so that photos can speak for themselves
  • Shared photo can be parsed by media-reader only when sharing them as "files" (e.g. sharing with gmail/gdrive, etc)
    • iOS: Share as "saving to files" instead of "saving to photos"
    • APPs like instagram, facebook will compress the photo and the photo can not be parsed with our media-reader

shc261392
shc261392 approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested on iPhone 7 Plus.

@shc261392 shc261392 merged commit b1bd7cb into develop Sep 2, 2021
@shc261392 shc261392 deleted the feature-share-cai-injected-photo branch September 2, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shc261392 shc261392 shc261392 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent10400094 @shc261392