Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make network status bar position consistent #607

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Make network status bar position consistent #607

merged 1 commit into from
Apr 1, 2021

Conversation

seanwu1105
Copy link
Contributor

According to the discussion of demo on 03/31/2021, we need to move the network status bar position below ion-segment on PostCaptureTabComponent.

Tested on Brave browser and Exodus 1.

@seanwu1105 seanwu1105 added this to the beta 13.5 milestone Apr 1, 2021
@seanwu1105 seanwu1105 self-assigned this Apr 1, 2021
shc261392
shc261392 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS

@seanwu1105 seanwu1105 merged commit b955381 into develop Apr 1, 2021
@seanwu1105 seanwu1105 deleted the fix-consistent-network-status-bar-position branch April 1, 2021 05:18
@seanwu1105 seanwu1105 modified the milestones: beta 13.5, beta 13.6 Apr 1, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shc261392 shc261392 shc261392 approved these changes

Assignees

@seanwu1105 seanwu1105

Labels
None yet
Projects
None yet
Milestone
beta 13.6
Development

Successfully merging this pull request may close these issues.
2 participants
@seanwu1105 @shc261392