Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI series #606

Merged
merged 16 commits into from
Apr 2, 2021
Merged

UI series #606

merged 16 commits into from
Apr 2, 2021

Conversation

CS6
Copy link
Contributor

@CS6 CS6 commented Mar 31, 2021

  • 頁面 1 的完整功能
  • 頁面 2 的 A, B 部分 (包含顯示 series 封面,以及留空的九宮格圖片顯示)
    關於頁面 3 的 C 部分 (按照 asset 是否擁有的狀況顯示 asset 或者底圖),這個部分等 QA 測完第一部分後,會請 @seanwu1105 接手
    換句話說,QA 測是你的 release 會期待
  • * 可以從 photo view 切換到 series view 再切回來,都不會有問題,可以正確看到 買過的 series

  • * 點選 series 封面會進入 collection view

  • * 在 collection view 底下,再點選上方的 series view icon 會回到 series view
    此部分之前已改為開新頁面顯示

  • * 在 collection view 底下,可以看到正確的 series 封面與留空的九宮格照片,但裡面目前並無法正確顯示照片

  • * 在 collection view 滑動的時候,封面照片會跟著滑動

  • 其他以上未提到的部分,基於 beta13.4

New series 封面樣式
image
image

@CS6 CS6 requested a review from seanwu1105 March 31, 2021 11:42
@CS6 CS6 self-assigned this Mar 31, 2021
@seanwu1105 seanwu1105 changed the base branch from master to uiux March 31, 2021 15:35
@CS6 CS6 marked this pull request as ready for review April 1, 2021 03:34
Copy link
Contributor

@seanwu1105 seanwu1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to pass build job in CI before requesting review.

@CS6 CS6 requested a review from seanwu1105 April 1, 2021 06:18
Copy link
Contributor

@seanwu1105 seanwu1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments in codes,

  • Remove commented codes.
  • Use readonly if possible.
  • Use undefined instead of null if possible.

id: string | null | undefined;
cover: string | null | undefined;
collectionGeneral = [
{ img: null },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace null with undefined if possible.

@@ -0,0 +1,52 @@
// tslint:disable: no-magic-numbers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why mark this "unresolved" converation resolved? Still, you did not remove the deprecated comments for TSLint.

@seanwu1105
Copy link
Contributor

seanwu1105 commented Apr 1, 2021

@CS6 Remember to pass all checks before requesting for review. Thanks.

@CS6 CS6 requested a review from seanwu1105 April 1, 2021 10:50
@@ -0,0 +1,52 @@
// tslint:disable: no-magic-numbers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why mark this "unresolved" converation resolved? Still, you did not remove the deprecated comments for TSLint.

@CS6 CS6 requested a review from seanwu1105 April 1, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants