Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom camera back button nav via angular router #2332

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

sultanmyrza
Copy link
Contributor

@sultanmyrza sultanmyrza commented Nov 23, 2022

Part of v221129-capture-app-ionic

Before we were using this.location.back(); to navigate back which works fine on iOS and Android. However, the QA reported that Pixel 6a use can not navigate back.

I was able to reproduce the issue and tried 3 versions to navigate back

  • this.navCtrl.back(); using NavController from "ionic/angular"
  • this.location.back();
  • this.router.navigate(['..']) worked on Android 6a

┆Issue is synchronized with this Asana task by Unito

@bafu bafu merged commit c400671 into develop Nov 29, 2022
@sultanmyrza sultanmyrza deleted the fix-android-back-button-via-router branch December 24, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants