Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild Information Details Page with Angular-Material Library #167

Merged
merged 6 commits into from
Nov 5, 2020
Merged

Rebuild Information Details Page with Angular-Material Library #167

merged 6 commits into from
Nov 5, 2020

Conversation

seanwu1105
Copy link
Contributor

@seanwu1105 seanwu1105 commented Nov 5, 2020 •
edited
Loading

Rebuild the page with new design. This PR depends on feature-proof-details #166. See #160 and #142.

@seanwu1105
WIP: rebuilding proof details page.
5c04662
@seanwu1105
Rebuild proof details with angular-material.
10c58d8 
- Rename default-information-provider to capacitor-provider.
- Rename default-signature-provider to web-crypto-api-provider.
- Only display the information from capacitor and the signature from web-crypto-api. Resolve #152, #153.
@seanwu1105
Merge branch 'develop' into feature-proof-details
576417e
@seanwu1105
Fix #142.
7ad9683 
- Remove unused publish button and make proof image fit to the width of the parent.
- Make Ionic AlertController and LoadingController use material-design mode.
@seanwu1105
Add empty line in scss to make linter happy.
470752d
@seanwu1105 seanwu1105 added the uiux UI or UX update label Nov 5, 2020
@seanwu1105 seanwu1105 added this to the beta6 milestone Nov 5, 2020
@seanwu1105 seanwu1105 requested a review from shc261392 November 5, 2020 02:30
@seanwu1105 seanwu1105 self-assigned this Nov 5, 2020
@seanwu1105 seanwu1105 force-pushed the feature-information-details branch from dfb3cd7 to 9f7df33 Compare November 5, 2020 02:33
@seanwu1105 seanwu1105 marked this pull request as ready for review November 5, 2020 03:58
@seanwu1105 seanwu1105 mentioned this pull request Nov 5, 2020
Merged
@shc261392 shc261392 merged commit 895e73e into develop Nov 5, 2020
@shc261392 shc261392 deleted the feature-information-details branch November 5, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shc261392 shc261392 shc261392 approved these changes

Assignees

@seanwu1105 seanwu1105

Labels
uiux UI or UX update
Projects
None yet
Milestone
beta6
Development

Successfully merging this pull request may close these issues.
2 participants
@seanwu1105 @shc261392